Skip to content

Unable to open in existing instance outside of code-server #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
code-asher opened this issue Dec 14, 2021 · 4 comments · Fixed by #4680
Closed

Unable to open in existing instance outside of code-server #4620

code-asher opened this issue Dec 14, 2021 · 4 comments · Fixed by #4680
Assignees
Labels
bug Something isn't working
Milestone

Comments

@code-asher
Copy link
Member

No description provided.

@code-asher code-asher added this to the 4.0.0 milestone Dec 14, 2021
@code-asher code-asher self-assigned this Dec 14, 2021
@code-asher code-asher changed the title Unable to open in existing instance outside of VS Code Unable to open in existing instance outside of code-server Dec 14, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 15, 2021

Can you elaborate on this?

@code-asher
Copy link
Member Author

Opening a file in a running instance of code-server only works inside VS Code's own terminal and not outside in an external terminal like it used to:

$ code-server -r /path/to/file
[2021-12-16T17:30:07.975Z] error got error from VS Code {"error":{"errno":"ENOENT","code":"ENOENT","syscall":"connect","address":"/run/user/1000/vscode-ipc-11493680-caf5-47f6-9318-e6a6838123ac.sock"}}

@code-asher
Copy link
Member Author

code-asher commented Dec 16, 2021

The problem is that we no longer store the socket path so code-server is not able to get the latest socket.

I think the move will be to delegate this functionality to VS Code by calling its CLI instead of hitting the socket directly. Ended up not being a viable option since it expects to be passed the socket.

@code-asher code-asher added the bug Something isn't working label Dec 21, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 3, 2022

Fixed via coder/vscode#33

@jsjoeio jsjoeio closed this as completed Jan 3, 2022
code-asher added a commit to code-asher/code-server that referenced this issue Jan 4, 2022
code-asher added a commit that referenced this issue Jan 4, 2022
* Update VS Code

Fixes #4598
Fixes #4620
Fixes #4600

* Add locale flag back

This is valid again now that we have restored display language support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants