Remove last opened functionality #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must handle this before we get to the browser because the first thing it does is create a workspace provider based on the provided workspace before any services are created which means we cannot fetch settings. So if we grab the last opened after that is done it has the wrong workspace and this breaks the close folder functionality (and possibly other things). Since it needs to be done on the server I figure I will implement in code-server to minimize the patch.
jsjoeio
approved these changes
Dec 15, 2021
|
Yup, exactly. I wish I could do it all in one PR! 🚀 |
Maybe one day! 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must handle this before we get to the browser because the first thing
it does is create a workspace provider based on the provided workspace
before any services are created which means we cannot fetch settings.
So if we grab the last opened after that is done it has the wrong
workspace and this breaks the close folder functionality (and possibly
other things).
Since it needs to be done on the server I figure I will implement in
code-server to minimize the patch.
coder/code-server#4619