Skip to content

Close folder does not appear to work #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
code-asher opened this issue Dec 14, 2021 · 0 comments · Fixed by #4633
Closed

Close folder does not appear to work #4619

code-asher opened this issue Dec 14, 2021 · 0 comments · Fixed by #4633
Assignees
@code-asher
Labels
bug Something isn't working
Milestone
4.0.1

Comments

@code-asher
Copy link
Member

No description provided.

@code-asher code-asher added the bug Something isn't working label Dec 14, 2021
@code-asher code-asher added this to the 4.0.0 milestone Dec 14, 2021
@code-asher code-asher self-assigned this Dec 14, 2021
@code-asher code-asher mentioned this issue Dec 15, 2021
Merged
code-asher added a commit to code-asher/code-server that referenced this issue Dec 15, 2021
@code-asher
Update VS Code
58ddeeb 
Fixes coder#3410
Fixes coder#4604
Fixes coder#4607
Fixes coder#4608
Fixes coder#4609

Also has the foundation for
coder#4619.
@code-asher code-asher mentioned this issue Dec 15, 2021
Merged
jsjoeio pushed a commit that referenced this issue Dec 15, 2021
@code-asher
Update VS Code (#4631)
73e0b79 
Fixes #3410
Fixes #4604
Fixes #4607
Fixes #4608
Fixes #4609

Also has the foundation for
#4619.
code-asher added a commit to code-asher/code-server that referenced this issue Dec 15, 2021
@code-asher
Implement last opened functionality
e4937c3 
Fixes coder#4619
@code-asher code-asher mentioned this issue Dec 16, 2021
Merged
code-asher added a commit to code-asher/code-server that referenced this issue Dec 16, 2021
@code-asher
Implement last opened functionality
21a39a1 
Fixes coder#4619
code-asher added a commit to code-asher/code-server that referenced this issue Dec 16, 2021
@code-asher
Implement last opened functionality
7b27250 
Fixes coder#4619
code-asher added a commit to code-asher/code-server that referenced this issue Dec 16, 2021
@code-asher
Implement last opened functionality
92865f2 
Fixes coder#4619
code-asher added a commit to code-asher/code-server that referenced this issue Dec 17, 2021
@code-asher
Implement last opened functionality
f482c2a 
Fixes coder#4619
code-asher added a commit that referenced this issue Dec 17, 2021
@code-asher
Implement last opened functionality (#4633)
c4c480a 
* Implement last opened functionality

Fixes #4619

* Fix test temp dirs not being cleaned up

* Mock logger everywhere

This suppresses all the error and debug output we generate which makes
it hard to actually find which test has failed.  It also gives us a
standard way to test logging for the few places we do that.

* Use separate data directories for unit test instances

Exactly as we do for the e2e tests.

* Add integration tests for vscode route

* Make settings use --user-data-dir

Without this test instances step on each other feet and they also
clobber your own non-test settings.

* Make redirects consistent

They will preserve the trailing slash if there is one.

* Remove compilation check

If you do a regular non-watch build there are no compilation stats so
this bricks VS Code in CI when running the unit tests.

I am not sure how best to fix this for the case where you have a build
that has not been packaged yet so I just removed it for now and added a
message to check if VS Code is compiling when in dev mode.

* Update code-server update endpoint name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.1
Development

Successfully merging a pull request may close this issue.

Implement last opened functionality code-asher/code-server
1 participant
@code-asher