Tweak certificate errors #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. That GitHub issue only has details for non-signing errors, which so far have not actually happened in the wild. 2. The information in the GitHub issue is not very straightforward. If we do end up needing to document non-signing errors, we should clean it up and put it in the docs.
code-asher
force-pushed
the
asher/tweak-cert-errors
branch
from
9bfa4d8 to
895c77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/coder/customers/issues/442
If testing, can use URLs from https://badssl.com (like https://incomplete-chain.badssl.com/).
Tweak error wording and show the detailed error under the input, so it will display in two places now.
Also remove the "view more details" button from the notification, for reasons detailed in the commit message.