Skip to content

Commit 9bfa4d8

Browse files
committed
Remove view more details from certificate error
1. That GitHub issue only has details for non-signing errors, which so far have not actually happened in the wild. 2. The information in the GitHub issue is not very straightforward. If we do end up needing to document non-signing errors, we should clean it up and put it in the docs.
1 parent 8c8e2d6 commit 9bfa4d8

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

src/error.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ interface KeyUsage {
3131

3232
export class CertificateError extends Error {
3333
public static ActionAllowInsecure = "Allow Insecure"
34-
public static ActionViewMoreDetails = "View More Details"
34+
public static ActionOK = "OK"
3535
public static InsecureMessage =
3636
'The Coder extension will no longer verify TLS on HTTPS requests. You can change this at any time with the "coder.insecure" property in your VS Code settings.'
3737

@@ -116,12 +116,6 @@ export class CertificateError extends Error {
116116
})
117117
}
118118

119-
viewMoreDetails(): Thenable<boolean> {
120-
return vscode.env.openExternal(
121-
vscode.Uri.parse("https://github.com/coder/vscode-coder/issues/115#issuecomment-1631512493"),
122-
)
123-
}
124-
125119
// allowInsecure updates the value of the "coder.insecure" property.
126120
async allowInsecure(): Promise<void> {
127121
vscode.workspace.getConfiguration().update("coder.insecure", true, vscode.ConfigurationTarget.Global)
@@ -146,11 +140,10 @@ export class CertificateError extends Error {
146140
// inside VS Code. Disabling the "Strict SSL" setting does not help
147141
// either. For now avoid showing the button until this is sorted.
148142
// CertificateError.ActionAllowInsecure,
149-
CertificateError.ActionViewMoreDetails,
143+
CertificateError.ActionOK
150144
)
151145
switch (val) {
152-
case CertificateError.ActionViewMoreDetails:
153-
await this.viewMoreDetails()
146+
case CertificateError.ActionOK:
154147
return
155148
case CertificateError.ActionAllowInsecure:
156149
await this.allowInsecure()

0 commit comments

Comments
 (0)