Skip to content

release: v1.1.0 #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

release: v1.1.0 #304

wants to merge 1 commit into from

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 13, 2024 •
edited
Loading

@pmareke @johnstcn
Add login_type to coder_workspace_owner data source #235 (#287)
0ffd87d 
* feat: add login_type to coder_workspace_owner data source

* feat: remove types check

* feat: update integration test

* feat: run linter

* feat: set empty string as the default value for the login type

* feat: update integration test

* feat: add a warning when the CODER_WORKSPACE_OWNER_LOGIN_TYPE is not set

* feat: create a new diags variable

* feat: add missing comma

* feat: add missing parenthesis

* feat: fix typo in summary field

Co-authored-by: Cian Johnston <[email protected]>

---------

Co-authored-by: Cian Johnston <[email protected]>
(cherry picked from commit 2598aa7)
@johnstcn johnstcn self-assigned this Nov 13, 2024
@johnstcn johnstcn changed the title Add login_type to coder_workspace_owner data source #235 (#287) [1.1 cherry] Add login_type to coder_workspace_owner data source #235 (#287) Nov 13, 2024
@johnstcn johnstcn changed the title [1.1 cherry] Add login_type to coder_workspace_owner data source #235 (#287) release: v1.1.0 Nov 13, 2024
@johnstcn johnstcn marked this pull request as draft November 13, 2024 14:43
@johnstcn johnstcn closed this Nov 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@dannykopping dannykopping Awaiting requested review from dannykopping

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @matifali @pmareke