Skip to content

feat: add login_type to coder_workspace_owner data source #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue May 28, 2024 · 11 comments
Closed

feat: add login_type to coder_workspace_owner data source #235

johnstcn opened this issue May 28, 2024 · 11 comments
Assignees
@johnstcn
Labels
good first issue Good for newcomers

Comments

@johnstcn
Copy link
Member

johnstcn commented May 28, 2024 •
edited by matifali
Loading

...we can expose account type, i.e., password, github, oidc, or none (could be extracted to a new issue) https://github.com/coder/terraform-provider-coder/assets/10648092/58097426-aed9-4f80-bcf9-75e8ab7358c0

_Originally posted by @matifali in _ https://github.com/coder/terraform-provider-coder/issues/219#issuecomment-2135511772
@johnstcn johnstcn mentioned this issue May 28, 2024
Closed
@matifali matifali added the good first issue Good for newcomers label Aug 20, 2024
@pmareke
Copy link
Contributor

pmareke commented Sep 9, 2024 •
edited
Loading

Hi, is this issue still open? I would like to give it a try.

@johnstcn
Copy link
Member Author

Hi, is this issue still open? I would like to give it a try.

Yes, this issue has not yet been worked on!

@pmareke
Copy link
Contributor

pmareke commented Sep 10, 2024

Great, done!

@pmareke pmareke mentioned this issue Sep 10, 2024
Merged
@matifali
Copy link
Member

Hi @pmareke thank your for your contribution. Could you run make gen to let the linter pass?

@pmareke
Copy link
Contributor

pmareke commented Sep 11, 2024

Hi @pmareke thank your for your contribution. Could you run make gen to let the linter pass?

Done!

johnstcn added a commit that referenced this issue Sep 11, 2024
@pmareke @johnstcn
Add login_type to coder_workspace_owner data source #235 (#287)
2598aa7 
* feat: add login_type to coder_workspace_owner data source

* feat: remove types check

* feat: update integration test

* feat: run linter

* feat: set empty string as the default value for the login type

* feat: update integration test

* feat: add a warning when the CODER_WORKSPACE_OWNER_LOGIN_TYPE is not set

* feat: create a new diags variable

* feat: add missing comma

* feat: add missing parenthesis

* feat: fix typo in summary field

Co-authored-by: Cian Johnston <[email protected]>

---------

Co-authored-by: Cian Johnston <[email protected]>
@johnstcn
Copy link
Member Author

#287 updates the provider to add the field. A separate PR will be required in coder/coder to set CODER_WORKSPACE_OWNER_LOGIN_TYPE.

@pmareke
Copy link
Contributor

pmareke commented Sep 11, 2024

Thanks so much @johnstcn, I really like doing the PR!

@dannykopping
Copy link
Contributor

dannykopping commented Nov 13, 2024 •
edited
Loading

#287 updates the provider to add the field. A separate PR will be required in coder/coder to set CODER_WORKSPACE_OWNER_LOGIN_TYPE.

@johnstcn do you know if there was a subsequent PR raised for this?
Right now the provider just raises a warning each time: Warning: WARNING: The CODER_WORKSPACE_OWNER_LOGIN_TYPE env variable is not set.

@matifali
Copy link
Member

matifali commented Nov 13, 2024 •
edited
Loading

Is it merged into release/1.0 branch?

@johnstcn
Copy link
Member Author

johnstcn commented Nov 13, 2024 •
edited
Loading

@dannykopping @matifali looks like it wasn't. I can add one quickly.
Edit: coder/coder#15499
Edit edit: the above PR has been merged to coder/coder#main, we can release the updated provider version closer to when we cut the next release

@johnstcn johnstcn mentioned this issue Nov 13, 2024
Merged
johnstcn added a commit that referenced this issue Nov 13, 2024
@pmareke @johnstcn
Add login_type to coder_workspace_owner data source #235 (#287)
0ffd87d 
* feat: add login_type to coder_workspace_owner data source

* feat: remove types check

* feat: update integration test

* feat: run linter

* feat: set empty string as the default value for the login type

* feat: update integration test

* feat: add a warning when the CODER_WORKSPACE_OWNER_LOGIN_TYPE is not set

* feat: create a new diags variable

* feat: add missing comma

* feat: add missing parenthesis

* feat: fix typo in summary field

Co-authored-by: Cian Johnston <[email protected]>

---------

Co-authored-by: Cian Johnston <[email protected]>
(cherry picked from commit 2598aa7)
@matifali
Copy link
Member

We will close it in release v2.0

@johnstcn johnstcn closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dannykopping @pmareke @johnstcn @matifali