Add CI #36
Add CI #36
Conversation
.github/test/Dockerfile
Outdated
|
|
||
| RUN apt update && \ | ||
| apt install -y shellcheck python-pip && \ | ||
| pip install autobahntestsuite |
There was a problem hiding this comment.
can remove this. and python-pip
nathanpotter
force-pushed
the
ci
branch
4 times, most recently
from
689f5e4 to
1576a6a
Compare
project.go
Outdated
| @@ -250,7 +250,9 @@ func (p *project) waitOnline() error { | |||
| cli := dockerClient() | |||
| defer cli.Close() | |||
|
|
|||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*10) | |||
| // Give a pretty significant amount of time since the `chown -R` call from | |||
There was a problem hiding this comment.
I played with a similar script I wrote myself but abandoned it because of this. I don't think its a good idea to merge this if the startup for a container starts taking a minute. Why does sail not work on travis? What uid is the user on travis created with?
There was a problem hiding this comment.
@nathanpotter according to the docs at https://github.com/boxboat/fixuid/tree/0ec93d22e52bde5b7326e84cb62fd26a3d20cead#overview
its shouldn't be chowning mounts so it shouldn't be slow, its changing the user inside the container to match the one outside.
There was a problem hiding this comment.
The user that runs the CI on travis is travis:travis with uid:gid 2000:2000
It says it changes all the file permissions for old uid:gid to be the new uid:gid, which is what seems to be taking so long. It appears to be doing this recursively on each of the mounts in /proc/mounts, see:
https://github.com/boxboat/fixuid/blob/0ec93d22e52bde5b7326e84cb62fd26a3d20cead/fixuid.go#L187
There was a problem hiding this comment.
I think in our CI, we should switch the travis user to uid 1000 instead of making sail do it as then regular users will experience the slowdown as well.
|
Can we get this merged and then resolve @nhooyr 's comments in another PR? I think CI is going to be important for this repo... A lot of moving parts. |
|
my comments are a blocker. The slowdown is too much and the fix I proposed is easy. |
|
Will update to use the new uid:gid and remove the fixuid |
No description provided.