will not work on multi user systems #52
Comments
|
Its only like a 5s delay so not crazy but still. |
|
If we're indiscriminately chmoding home, isn't it possible we override some intentionally set permissions? |
|
We're chowning it which should be fine. |
|
Is that because chown doesn't propogate a mac mount? Confused |
|
Its extremely unlikely any of the mounts contain files owned by a different user. an alternative approach we could take is to pass in the UID to the build container as a build arg so that the image itself has the right uid from the get go. |
|
In the rare case there is, there can be some minor corruption. E.g, what if they sshfs a server to some directory in home? I know i've done that before.. This could infinitely traverse my remote server and fuck me up good. |
|
Just read the manpage, it turns out it only chowns files already owned by the user. Not sure how this interacts with mounts though. I'll give it a test. |
|
That doesn't make any sense... If the file is already owned by the user what good does chowning it to the same user do? |
|
Files aren't owned by the user, they're owned by the UID. |
|
isn't the uid 1:1 associated with user |
|
Yes, but if you change the UID for a user, you need to chown every file such thats its owned by the new UID. |
Updates #52 Still no good support for multi user systems but I think that's fine for now.
Updates #52 Still no good support for multi user systems but I think that's fine for now.
|
So turns out, the osxfs driver does the right thing by default: https://stackoverflow.com/questions/43097341/docker-on-macosx-does-not-translate-file-ownership-correctly-in-volumes |
|
So multi user systems are supported on macOS without any changes. Just linux that will end up being an issue. |
Updates #52 Still no good support for linux multi user systems but I think that's fine for now.
Updates #52 Still no good support for multi user linux systems.
Updates #52 Still no good support for multi user linux systems.
nhooyr
changed the title
|
might be useful: https://github.com/boxboat/fixuid |
|
Using that |
|
Going to close as it has been a while and I'm not sure if this is relevant anymore. |
On any system where the user uid is not 1000, like macOS or multiple user systems, sail will be very slow due to the
usermod -ustep to adjust the uid inside the container to the one outside because it has to chown all files in the home folder.I do not have a good solution for this.
See #51
The text was updated successfully, but these errors were encountered: