chore: extract option defaults to options package #283
+174
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
changed the title
mafredri
approved these changes
Jul 29, 2024
| // Temporarily removed these from the default settings to prevent conflicts | ||
| // between current and legacy environment variables that add default values. | ||
| // Once the legacy environment variables are phased out, this can be | ||
| // reinstated to the previous default values. |
There was a problem hiding this comment.
I know this was just moved and logic didn't change, but I wonder what this comment means. 🤔
There was a problem hiding this comment.
Related to ENVBUILDER_ env prefix.
Signed-off-by: Cian Johnston <[email protected]>
Signed-off-by: Cian Johnston <[email protected]>
Signed-off-by: Cian Johnston <[email protected]>
johnstcn
force-pushed
the
cj/option-defaults
branch
from
4df4433 to
fd6ef17
Compare
johnstcn
added a commit
that referenced
this pull request
Jul 31, 2024
johnstcn
added a commit
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Cian Johnston <[email protected]> (cherry picked from commit 09ce456)
johnstcn
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of coder/internal#11
Builds on top of #282
More refactoring: