chore: extract constants package #282
Conversation
Signed-off-by: Cian Johnston <[email protected]>
| // to skip building when a container is restarting. | ||
| // e.g. docker stop -> docker start | ||
| MagicFile = filepath.Join(MagicDir, "built") | ||
| ) |
There was a problem hiding this comment.
I do feel like this and options belong in the same package, how about merging them under core or something? Not sure it's better description wise but still. Ideally I'd love for these and options to be in the package named envbuilder since that makes the most sense. But then we either lose the separation, or need to move the Run method elsewhere.
I suppose a build package could be appropriate for those, but then we'd kinda revert some of the splits you've already been doing.
| @@ -0,0 +1,31 @@ | |||
| package constants | |||
There was a problem hiding this comment.
Two alternatives, config and defaults. Not sure if/which would be better.
There was a problem hiding this comment.
I personally dislike both of those options 😅 but I don't have a better proposal.
|
I'm going to go ahead and merge this. We can rename / break this up more later if needed. |
Signed-off-by: Cian Johnston <[email protected]> (cherry picked from commit cc0b4c5)
Part of coder/internal#11
open to naming this something else, but
constantswas what came to mind first.