-
Notifications
You must be signed in to change notification settings - Fork 43
feat: embed binary in image when pushing image #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f0ab230
Add tests to verify embed binary image
BrunoQuaresma 0cab914
update test to check built image
johnstcn 45960bb
Merge branch 'main' into bq/embed-binary
BrunoQuaresma cecd662
Update ctx and copy .envbuilder to image
BrunoQuaresma 3eb4217
Try to copy bin to .devcontainer to include it in build context
BrunoQuaresma 4138dc5
Simple copy file operation
mtojek 19b235d
use feature added in coder/kaniko#16
johnstcn f2c6912
update kaniko fork in go.mod
johnstcn 0c902f3
Merge remote-tracking branch 'origin/main' into bq/embed-binary
johnstcn baef8fc
fmt
johnstcn a250901
AllowedPaths is now a slice
johnstcn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would annotate this test file with given/when/then markers.