feat: embed binary in image when pushing image #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jun 13, 2024
BrunoQuaresma
commented
Jun 13, 2024
mtojek
reviewed
Jun 14, 2024
| @@ -1354,6 +1355,74 @@ COPY --from=a /root/date.txt /date.txt`, testImageAlpine, testImageAlpine), | |||
| }) | |||
| } | |||
|
|
|||
| func TestEmbedBinaryImage(t *testing.T) { | |||
There was a problem hiding this comment.
I would annotate this test file with given/when/then markers.
| _, err = remote.Image(ref) | ||
| require.NoError(t, err, "expected image to be present after build + push") | ||
|
|
||
| ctx := context.Background() |
There was a problem hiding this comment.
It is not a problem at all, but a cleaner approach would be:
ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
defer cancel()
mtojek
reviewed
Jun 14, 2024
johnstcn
changed the title
mtojek
reviewed
Jun 24, 2024
mtojek
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #216
Embeds the envbuilder binary in the image under the same path when pushing.
Depends on coder/kaniko#16