-
Notifications
You must be signed in to change notification settings - Fork 862
chore: add "user_configs"
db table
#16564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pls don't close my pr github |
6f61953
to
0590d77
Compare
Since we're no longer sending the |
@ethanndickson would it suffice to re-add the field in the /api/v2/users response but mark it as deprecated? EDIT: this was already done as part of this PR, the only other change was adding |
I think the change is fine honestly, but if it's breaking our own Coder integration (desktop), it's possible it could break someone else's. |
Adds a
"user_configs"
tableMoves the data from the
"users"."theme_preference"
column to this new table as a bit of a proof of conceptThe idea is that this table will enable future feature development to have a nice spot to put user specific settings, like storing the state of dismissed notification banners, or other UI personalizations that we may add in the future. It could even be used to remember values from partial form completions, or all manner of other things, (and in a place where they can later be invalidated by the backend, rather than put in
localStorage
)