fix: handle missing user theme_preference on sign in
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
ethan/handle-breaking-user-response
branch
from
404de0d to
ff5b5c0
Compare
deansheather
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coder/coder#16564 has the Coder server no longer send the
theme_preferencefield in a/api/v2/userresponse.The Swift
JSONDecoderrequires that a missing field be explicitly marked as optional, else the deserialization fails. To make it less likely this happens again, we'll only requireidandusernamebe present.We'll do the same for the other SDK types and only require the minimum fields the app needs be present.
This PR also improves the error message on any decoding error:
