Skip to content

feat(ci): add lint-actions step to build.yaml #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 9, 2023

This adds a new job to the Build CI pipeline to lint our GitHub Actions.

By doing this, we can prevent typos from slipping in.

Fixes #5776

This adds a new job to the Build CI pipeline to lint our GitHub Actions.

By doing this, we can prevent typos from slipping in.

Fixes #5776
@jsjoeio jsjoeio self-assigned this Jan 9, 2023
@jsjoeio jsjoeio marked this pull request as ready for review January 9, 2023 18:18
@jsjoeio jsjoeio requested a review from a team as a code owner January 9, 2023 18:18
@jsjoeio jsjoeio temporarily deployed to npm January 9, 2023 18:20 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

✨ code-server dev build published to npm for PR #5957!

  • Last publish status: success
  • Commit: 642725a

To install in a local project, run:

npm install @coder/code-server-pr@5957

To install globally, run:

npm install -g @coder/code-server-pr@5957

I don't think we want to enable this for now.
It's deprecated but there isn't a reason to move away from using it yet.
@jsjoeio jsjoeio temporarily deployed to npm January 9, 2023 18:48 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm January 9, 2023 20:39 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm January 9, 2023 23:00 — with GitHub Actions Inactive
uses: actions/checkout@v3
- name: Check workflow files
run: |
bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin the version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Good thinking... I'll pick a commit instead of using main.

@jsjoeio jsjoeio enabled auto-merge (squash) January 13, 2023 17:05
@jsjoeio jsjoeio temporarily deployed to npm January 13, 2023 17:07 — with GitHub Actions Inactive
@jsjoeio jsjoeio merged commit d40a974 into main Jan 13, 2023
@jsjoeio jsjoeio deleted the jsjoeio/gh-action-linting branch January 13, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Add github action linting
2 participants