Skip to content

[Feat]: Add github action linting #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Nov 10, 2022 · 0 comments · Fixed by #5957
Closed

[Feat]: Add github action linting #5776

jsjoeio opened this issue Nov 10, 2022 · 0 comments · Fixed by #5957
Labels
enhancement Some improvement that isn't a feature
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 10, 2022

I accidentally merged a PR with a typo in release.yaml. This should have been caught.

We should add a step to CI which lints our GitHub Workflow files.

https://github.com/rhysd/actionlint

@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Nov 10, 2022
@jsjoeio jsjoeio added this to the November 2022 milestone Nov 10, 2022
@jsjoeio jsjoeio changed the title [Feat]: Add yaml linting [Feat]: Add github action linting Nov 10, 2022
jsjoeio added a commit that referenced this issue Jan 9, 2023
This adds a new job to the Build CI pipeline to lint our GitHub Actions.

By doing this, we can prevent typos from slipping in.

Fixes #5776
jsjoeio added a commit that referenced this issue Jan 13, 2023
* feat(ci): add lint-actions step to build.yaml

This adds a new job to the Build CI pipeline to lint our GitHub Actions.

By doing this, we can prevent typos from slipping in.

Fixes #5776

* fix: disable shellcheck in actionlint

I don't think we want to enable this for now.

* fix: ignore set-output warnings for now

It's deprecated but there isn't a reason to move away from using it yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant