Skip to content

fix: minor fixes related to release #5732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 1, 2022
Merged

fix: minor fixes related to release #5732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec50137
fix: use * for test plugin engines
jsjoeio Oct 28, 2022
b62cee4
refactor: use npm-package in release assets
jsjoeio Oct 28, 2022
89eae59
docs: update release instructions
jsjoeio Oct 28, 2022
2806d39
fixup!: use package.tar.gz
jsjoeio Oct 28, 2022
bb0251a
Merge branch 'main' into jsjoeio/minor-release-changes
jsjoeio Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@ jobs:
id: version
run: echo "::set-output name=version::$(jq -r .version package.json)"

- name: Download artifact
uses: dawidd6/action-download-artifact@v2
id: download
- name: Download npm package from release artifacts
uses: robinraju/[email protected]
with:
branch: release/v${{ steps.version.outputs.version }}
workflow: build.yaml
workflow_conclusion: completed
name: "npm-package"
path: release-npm-package
repository: "coder/code-server"
tag: v${{ steps.version.outputs.version }}
fileName: "package.tar.gz"
out-file-path: "release-npm-package"

- name: Publish npm package and tag with "latest"
run: yarn publish:npm
Expand Down
21 changes: 21 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,3 +249,24 @@ jobs:
draft: true
discussion_category_name: "📣 Announcements"
files: ./release-packages/*

npm-package:
name: Upload npm package
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: Download artifacts
uses: dawidd6/action-download-artifact@v2
id: download
with:
branch: ${{ github.ref }}
workflow: build.yaml
workflow_conclusion: completed
check_artifacts: true
name: npm-package

- uses: softprops/action-gh-release@v1
with:
draft: true
discussion_category_name: "📣 Announcements"
files: ./package.tar.gz
3 changes: 1 addition & 2 deletions docs/MAINTAINING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ changelog](https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS).

### Publishing a release

1. Create a new branch called `release/v0.0.0` (replace 0s with actual version aka v4.5.0)
1. If you don't do this, the `npm-brew` GitHub workflow will fail. It looks for the release artifacts under the branch pattern.
1. Create a new branch called `release`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should still call this release/v{version} because it is more descriptive of the changeset. Plus it could get weird if we ever need to backport or release multiple versions at once and if you have an old release branch checked out you would have to force reset which could seem weird because you might think "I have never checked out this release before" but because the name is shared git thinks you have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point! Okay, I'll revert this doc change but remove that other line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna do that in other PR

1. Run `yarn release:prep`
1. Bump chart version in `Chart.yaml`.
1. Summarize the major changes in the `CHANGELOG.md`
Expand Down
2 changes: 1 addition & 1 deletion test/unit/node/test-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "test-plugin",
"version": "1.0.0",
"engines": {
"code-server": "^4.8.1"
"code-server": "*"
},
"main": "out/index.js",
"devDependencies": {
Expand Down