fix: minor fixes related to release #5732
Conversation
This removes the need to update this version with every version change.
jsjoeio
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5732 +/- ##
=======================================
Coverage 72.65% 72.65%
=======================================
Files 30 30
Lines 1682 1682
Branches 369 369
=======================================
Hits 1222 1222
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
This adds a new job to `release.yaml` to upload the `npm-package` to the release assets which will also allow us to download it in the `publish.yaml` workflow.
|
✨ code-server docs for PR #5732 is ready! It will be updated on every commit.
|
|
|
| @@ -141,8 +141,7 @@ changelog](https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS). | |||
|
|
|||
| ### Publishing a release | |||
|
|
|||
| 1. Create a new branch called `release/v0.0.0` (replace 0s with actual version aka v4.5.0) | |||
| 1. If you don't do this, the `npm-brew` GitHub workflow will fail. It looks for the release artifacts under the branch pattern. | |||
| 1. Create a new branch called `release` | |||
There was a problem hiding this comment.
I wonder if we should still call this release/v{version} because it is more descriptive of the changeset. Plus it could get weird if we ever need to backport or release multiple versions at once and if you have an old release branch checked out you would have to force reset which could seem weird because you might think "I have never checked out this release before" but because the name is shared git thinks you have.
There was a problem hiding this comment.
That's a good point! Okay, I'll revert this doc change but remove that other line
There was a problem hiding this comment.
Gonna do that in other PR
* chore: bump version to 4.8.2 * chore: update CHANGELOG * docs: add back line in publishing release See #5732 (comment) * Revert "chore: bump version to 4.8.2" This reverts commit 5d70994. * fixup: use 4.8.2-rc.1 * docs: add release candidate notes * refactor: warn plugin range incompatibble * chore: bump version 4.8.2
Description
This makes some minor changes to progress us towards a smoother release.
Testing Plan
Fixes #5148