Skip to content

refactor: heartbeat patch #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2022
Merged

refactor: heartbeat patch #5545

merged 2 commits into from
Sep 9, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 9, 2022

This removes the heartbeat patch because the functionality has been implemented upstream in microsoft/vscode#159239

H/T to @code-asher for finding it!

@jsjoeio jsjoeio requested a review from a team as a code owner September 9, 2022 17:15
@jsjoeio jsjoeio linked an issue Sep 9, 2022 that may be closed by this pull request
@jsjoeio jsjoeio self-assigned this Sep 9, 2022
@jsjoeio jsjoeio enabled auto-merge (squash) September 9, 2022 17:17
@jsjoeio jsjoeio temporarily deployed to npm September 9, 2022 17:32 Inactive
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

✨ code-server dev build published to npm for PR #5545!

  • Last publish status: success
  • Commit: ac351e4

To install in a local project, run:

npm install @coder/code-server-pr@5545

To install globally, run:

npm install -g @coder/code-server-pr@5545

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #5545 (ac351e4) into main (3fb3841) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5545   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb3841...ac351e4. Read the comment docs.

@jsjoeio jsjoeio merged commit 5028169 into main Sep 9, 2022
@jsjoeio jsjoeio deleted the 5544-chore-remove-heartbeat-patch branch September 9, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore]: Remove heartbeat patch
2 participants