Skip to content

Commit 3fb3841

Browse files
authored
docs: update patch testing instructions (#5543)
* docs: explain how to test exec-argv * docs: explain how to test telemetry patch
1 parent b486354 commit 3fb3841

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

patches/exec-argv.diff

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
Preserve process.execArgv
22

3-
This ensures flags like --prof are passed down so we can profile everything.
3+
This ensures flags like `--prof` are passed down to the code-server process so
4+
we can profile everything.
5+
6+
To test this:
7+
1. run `./lib/node --prof .`
8+
2. in another terminal, run `ps -ejww`
9+
10+
You should see `--prof` next to every code-server process.
411

512
Index: code-server/lib/vscode/src/vs/server/node/extensionHostConnection.ts
613
===================================================================

patches/telemetry.diff

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@ Add support for telemetry endpoint
22

33
Contains some fixes included in https://github.com/microsoft/vscode/commit/b108bc8294ce920fcf2ee8d53f97c3bcf3316e1c
44

5+
To test:
6+
1. Look inside a build of code-server, inside `lib/vscode/vs/server/node/server.main.js`
7+
2. Search for a `JSON.stringify` near `TelemetryClient`
8+
3. throw in a `console.log()` before it and make sure it logs telemetry data
9+
510
Index: code-server/lib/vscode/src/vs/server/node/serverServices.ts
611
===================================================================
712
--- code-server.orig/lib/vscode/src/vs/server/node/serverServices.ts

0 commit comments

Comments
 (0)