Skip to content

docs: update patch testing instructions #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2022
Merged

docs: update patch testing instructions #5543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
367014a
docs: explain how to test exec-argv
jsjoeio Sep 8, 2022
e784d68
docs: explain how to test telemetry patch
jsjoeio Sep 8, 2022
88f8812
Merge branch 'main' into jsjoeio/update-patches
jsjoeio Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion patches/exec-argv.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
Preserve process.execArgv

This ensures flags like --prof are passed down so we can profile everything.
This ensures flags like `--prof` are passed down to the code-server process so
we can profile everything.

To test this:
1. run `./lib/node --prof .`
2. in another terminal, run `ps -ejww`

You should see `--prof` next to every code-server process.

Index: code-server/lib/vscode/src/vs/server/node/extensionHostConnection.ts
===================================================================
Expand Down
5 changes: 5 additions & 0 deletions patches/telemetry.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ Add support for telemetry endpoint

Contains some fixes included in https://github.com/microsoft/vscode/commit/b108bc8294ce920fcf2ee8d53f97c3bcf3316e1c

To test:
1. Look inside a build of code-server, inside `lib/vscode/vs/server/node/server.main.js`
2. Search for a `JSON.stringify` near `TelemetryClient`
3. throw in a `console.log()` before it and make sure it logs telemetry data

Index: code-server/lib/vscode/src/vs/server/node/serverServices.ts
===================================================================
--- code-server.orig/lib/vscode/src/vs/server/node/serverServices.ts
Expand Down