fix: file/directory opens from terminal #5340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
cli-window-open
branch
from
96613e5 to
64b8a70
Compare
Codecov Report
@@ Coverage Diff @@
## main #5340 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 30 30
Lines 1671 1671
Branches 367 367
=======================================
Hits 1211 1211
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
jsjoeio
approved these changes
Jul 15, 2022
Comment on lines
+5
to
+14
| To test: | ||
|
|
||
| 1. Run code-server | ||
| 2. Open code-server | ||
| 3. Open terminal | ||
| 4. Open another code-server window | ||
| 5. Run code-server with a file or directory argument | ||
|
|
||
| The file or directory should only open from the instance attached to that | ||
| terminal. |
There was a problem hiding this comment.
This is really well-written!
Comment on lines
+24
to
+34
| - private readonly _onExecuteCommand = this._register(new Emitter<{ reqId: number; commandId: string; commandArgs: any[] }>()); | ||
| + private readonly _onExecuteCommand = this._register(new Emitter<{ reqId: number; terminalId: number; commandId: string; commandArgs: any[] }>()); | ||
| readonly onExecuteCommand = this._onExecuteCommand.event; | ||
|
|
||
| constructor( | ||
| @@ -240,20 +240,20 @@ export class RemoteTerminalChannel exten | ||
| const ipcHandlePath = createRandomIPCHandle(); | ||
| env.VSCODE_IPC_HOOK_CLI = ipcHandlePath; | ||
| const commandsExecuter: ICommandsExecuter = { | ||
| - executeCommand: <T>(id: string, ...args: any[]): Promise<T> => this._executeCommand(id, args, uriTransformer) | ||
| + executeCommand: <T>(commandId: string, ...args: any[]): Promise<T> => this._executeCommand(terminalId, commandId, args, uriTransformer) |
There was a problem hiding this comment.
Very happy to see this be a small change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5339
More info can be found in the patch notes.