Skip to content

[Bug]: multiple code-server windows opened with code-server #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
jsjoeio opened this issue Jul 14, 2022 · 1 comment · Fixed by #5340
Closed
4 tasks done

[Bug]: multiple code-server windows opened with code-server #5339

jsjoeio opened this issue Jul 14, 2022 · 1 comment · Fixed by #5340
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 14, 2022

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: any
  • Local OS: any
  • Remote OS: any
  • Remote Architecture: any
  • code-server --version: 4.5.0

Steps to Reproduce

  1. open code-server
  2. inside terminal, run code-server .
  3. do it again
  4. see each window try to open a new code-server window

Expected

only the window where the command was run should try to open

Actual

each open window tries to open another window

Logs

No response

Screenshot/Video

mark--.mp4

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

Found in Code v1

Maybe here

yeah we just send a message to the socket
so if it is opening in multiple windows it might be on the vs code side
so all windows share the socket
and they all get the same message

image

@jsjoeio jsjoeio added bug Something isn't working triage This issue needs to be triaged by a maintainer and removed triage This issue needs to be triaged by a maintainer labels Jul 14, 2022
@jsjoeio jsjoeio added this to the 4.5.1 milestone Jul 14, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 14, 2022

Investigation Notes

We wanted to determine if this was upstream in VS Code so we did the following:

  1. yarn watch
  2. open code-server
  3. open terminal
  4. open another code-server window
  5. node lib/vscode/out/server-cli.js <any directory>

The same bug happens. This means the bug exists in the VS Code CLI.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants