feat(testing): add test for parse when error in args + config
#4866
Conversation
| @@ -218,8 +218,8 @@ describe("update", () => { | |||
| it("should reject if response has status code 500", async () => { | |||
| if (isAddressInfo(_address)) { | |||
| const mockURL = `http://${_address.address}:${_address.port}/reject-status-code` | |||
| let provider = new UpdateProvider(mockURL, settings()) | |||
| let update = await provider.getUpdate(true) | |||
| const provider = new UpdateProvider(mockURL, settings()) | |||
There was a problem hiding this comment.
Very strange...I didn't make this change but when I ran yarn lint or yarn fmt locally, this changed happened?
There was a problem hiding this comment.
Huh I think we are passing --fix to auto-fix but I did not know they would change let to const.
There was a problem hiding this comment.
I didn't either! Maybe a new thing? Or maybe I did something janky...no idea
There was a problem hiding this comment.
Could be something new! Either way, const looks right since we are not changing these values.
Codecov Report
@@ Coverage Diff @@
## main #4866 +/- ##
==========================================
+ Coverage 69.73% 69.79% +0.06%
==========================================
Files 29 29
Lines 1649 1649
Branches 363 363
==========================================
+ Hits 1150 1151 +1
+ Misses 425 424 -1
Partials 74 74
Continue to review full report at Codecov.
|
|
✨ Coder.com for PR #4866 deployed! It will be updated on every commit.
|
…r#4866) * chore: fmt cleanup * feat(parse): add test error w/config
This adds a test for
parseto hit a line where an error is thrown with a bad arg and a config file path are passed in.Fixes #4858