Skip to content

[Testing]: add more coverage for parse function in cli.ts #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Feb 18, 2022 · 0 comments · Fixed by #4898
Closed

[Testing]: add more coverage for parse function in cli.ts #4885

jsjoeio opened this issue Feb 18, 2022 · 0 comments · Fixed by #4898
Assignees
@jsjoeio
Labels
enhancement Some improvement that isn't a feature
Milestone
4.1.0

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 18, 2022 •
edited
Loading

L359 in cli.ts is not covered (the continue):

https://github.com/coder/code-server/blob/main/src/node/cli.ts#L358-L360

I'd like to add a test, similar to #4866

How to test

Pass an arg that is an OptionalString and set it to false such as --cert
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Feb 18, 2022
@jsjoeio jsjoeio added this to the 4.0.3 milestone Feb 18, 2022
@jsjoeio jsjoeio self-assigned this Feb 18, 2022
@jsjoeio jsjoeio changed the title [Testing]: [Testing]: add more coverage for parse function in cli.ts Feb 18, 2022
@jsjoeio jsjoeio mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

feat(testing): add new test for cli.ts coder/code-server
1 participant
@jsjoeio