Skip to content

fix: reverse logic in brew-bump env fns #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 12, 2022

This PR uses is_env_var_set correctly.

Fixes #4686

@jsjoeio jsjoeio requested a review from a team January 12, 2022 21:27
@jsjoeio jsjoeio self-assigned this Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #4732 (70e70db) into main (15500bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4732   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files          29       29           
  Lines        1638     1638           
  Branches      341      341           
=======================================
  Hits         1134     1134           
  Misses        428      428           
  Partials       76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15500bb...70e70db. Read the comment docs.

@github-actions
Copy link

✨ Coder.com for PR #4732 deployed! It will be updated on every commit.

@jsjoeio jsjoeio merged commit 48ddad8 into main Jan 12, 2022
@jsjoeio jsjoeio deleted the jsjoeio-fix-hb-script branch January 12, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix homebrew release script
2 participants