Skip to content

Fix homebrew release script #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Jan 5, 2022 · 0 comments · Fixed by #4732
Closed

Fix homebrew release script #4686

jsjoeio opened this issue Jan 5, 2022 · 0 comments · Fixed by #4732
Assignees
@jsjoeio
Labels
chore Related to maintenance or clean up
Milestone
4.0.2

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 5, 2022

I thought we fixed this but apparently it can't find the version so the script failed with the 4.0.1 release

https://github.com/coder/code-server/runs/4719644203?check_suite_focus=true

I think the best thing to do is recreate a very basic repo and get it working there and then update it in code-server.

Third try is a charm they say!
@jsjoeio jsjoeio self-assigned this Jan 5, 2022
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Jan 5, 2022
@jsjoeio jsjoeio modified the milestones: 4.1.0 - improve iPad UX, 4.0.2 Jan 5, 2022
@jsjoeio jsjoeio mentioned this issue Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
chore Related to maintenance or clean up
Projects
None yet
Milestone
4.0.2
Development

Successfully merging a pull request may close this issue.

fix: reverse logic in brew-bump env fns coder/code-server
1 participant
@jsjoeio