-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Significantly improve the Dockerfile #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54cf52c
to
cae2b3f
Compare
Will need to update the README.md with a command to mount into |
Unfortunately, dumb-init is not sending signals properly when using the |
Nvm, got it working. See https://stackoverflow.com/questions/41097652/how-to-fix-ctrlc-inside-a-docker-container |
@nhooyr Great you got it working. |
Passwordless sudo is like an always-open door (in the real world). There is definitely a room for improvement. |
@frol its still teaching basic practice anyways, so I don't think primarily its open door especially if its just a container (and the fact GCP practices this as well due to the fact - you know, they're SSH keys only by default). |
We could prompt users to set a password on startup later @frol but for now this is a simple improvement. |
I vote against that IMHO, I don't think we need to support that kind of use case especially in Docker. The user should do it themselves if they really want to. We just provide a sane default for them. |
Asking for a password is a safe default and the common use case. What we're providing is the exception. |
Significantly improve the Dockerfile
closes Switch to an LTS version of Ubuntu (18.04) for the Dockerfile #404
Thanks to @RichardMcSorley and @sr229
Describe in detail the problem you had and how this PR fixes it
Is there an open issue you can link to?