Skip to content

docker one-liner should use the -i flag #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhooyr opened this issue Mar 27, 2019 · 0 comments · Fixed by #433
Closed

docker one-liner should use the -i flag #361

nhooyr opened this issue Mar 27, 2019 · 0 comments · Fixed by #433

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Mar 27, 2019

Otherwise signals aren't passed correctly and the container keeps running in the bg.

Also, we need to make code-server handle signals correctly.
@RichardMcSorley RichardMcSorley mentioned this issue Apr 3, 2019
Closed
nhooyr added a commit that referenced this issue Apr 4, 2019
@nhooyr
Significantly improve the Dockerfile
85b273f 
- Adds dumb-init so closes #403, closes #361, closes #383
- User mode docker so closes #192, closes #65
- Uses latest docker ubuntu instead of 18.10 which is the rolling tag so closes #404

Thanks to @RichardMcSorley and @sr229
@nhooyr nhooyr mentioned this issue Apr 4, 2019
Merged
nhooyr added a commit that referenced this issue Apr 4, 2019
@nhooyr
Significantly improve the Dockerfile
b24621f 
- Adds dumb-init so closes #403, closes #361, closes #383
- User mode docker so closes #192, closes #65
- Uses latest docker ubuntu instead of 18.10 which is the rolling tag so closes #404

Thanks to @RichardMcSorley and @sr229
nhooyr added a commit that referenced this issue Apr 4, 2019
@nhooyr
Significantly improve the Dockerfile
54cf52c 
- Adds dumb-init so closes #403, closes #361, closes #383
- User mode docker so closes #192, closes #65
- Uses latest docker ubuntu instead of 18.10 which is the rolling tag so closes #404

Thanks to @RichardMcSorley and @sr229
nhooyr added a commit that referenced this issue Apr 4, 2019
@nhooyr
Significantly improve the Dockerfile
cae2b3f 
- Adds dumb-init so closes #403, closes #361, closes #383
- User mode docker so closes #192, closes #65
- Uses latest docker ubuntu instead of 18.10 which is the rolling tag so closes #404

Thanks to @RichardMcSorley and @sr229
nhooyr added a commit that referenced this issue Apr 4, 2019
@nhooyr
Significantly improve the Dockerfile
ebac848 
- Adds dumb-init so closes #403, closes #361, closes #383
- User mode docker so closes #192, closes #65
- Uses latest docker ubuntu instead of 18.10 which is the rolling tag so closes #404

Thanks to @RichardMcSorley and @sr229
code-asher pushed a commit that referenced this issue Jun 19, 2019
@nhooyr
Significantly improve the Dockerfile
be709d4 
- Adds dumb-init so closes #403, closes #361, closes #383
- User mode docker so closes #192, closes #65
- Uses latest docker ubuntu instead of 18.10 which is the rolling tag so closes #404

Thanks to @RichardMcSorley and @sr229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Significantly improve the Dockerfile coder/code-server
1 participant
@nhooyr