Skip to content

feat(cli): add tests for password, hashed-password #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 4, 2021

This PR adds tests for code-server/src/node/cli.ts to cover lines 314,318.

Fixes N/A

#TestingMondays

@jsjoeio jsjoeio self-assigned this Oct 4, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #4309 (45319ec) into main (8a4ed5a) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4309      +/-   ##
==========================================
+ Coverage   68.09%   68.22%   +0.12%     
==========================================
  Files          31       31              
  Lines        1586     1586              
  Branches      308      308              
==========================================
+ Hits         1080     1082       +2     
+ Misses        432      430       -2     
  Partials       74       74              
Impacted Files Coverage Δ
src/node/cli.ts 82.30% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4ed5a...45319ec. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

✨ Coder.com for PR #4309 deployed! It will be updated on every commit.

@jsjoeio jsjoeio marked this pull request as ready for review October 4, 2021 22:15
@jsjoeio jsjoeio requested a review from a team as a code owner October 4, 2021 22:15
@jsjoeio jsjoeio merged commit 271bc06 into main Oct 5, 2021
@jsjoeio jsjoeio deleted the jsjoeio-test-monday branch October 5, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants