Skip to content

Commit 8a4ed5a

Browse files
authored
Merge pull request #4306 from cdr/jsjoeio-fix-broken-tests
fix: revert CI change + fix broken tests
2 parents 672038c + a8d873f commit 8a4ed5a

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/ci.yaml

+4-3
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ jobs:
5454
run: yarn lint
5555
if: success()
5656

57+
- name: Run code-server unit tests
58+
run: yarn test:unit
59+
if: success()
60+
5761
- name: Upload coverage report to Codecov
5862
run: yarn coverage
5963
if: success()
@@ -404,9 +408,6 @@ jobs:
404408
rm -r node_modules/playwright
405409
yarn install --check-files
406410
407-
- name: Run end-to-end tests
408-
run: yarn test:unit
409-
410411
- name: Run end-to-end tests
411412
run: yarn test:e2e
412413

src/node/routes/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ export const register = async (
162162
}
163163

164164
server.on("close", () => {
165-
vscode.vscodeServer.close()
165+
vscode?.vscodeServer.close()
166166
})
167167

168168
app.use(() => {

test/unit/node/routes/static.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as integration from "../../../utils/integration"
77

88
const NOT_FOUND = {
99
code: 404,
10-
message: "not found",
10+
message: "Not Found",
1111
}
1212

1313
describe("/_static", () => {

0 commit comments

Comments
 (0)