Skip to content

Make native-keymap and keytar optional dependencies #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ci/dev/postinstall.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ set -euo pipefail
main() {
cd "$(dirname "$0")/../.."

echo 'Installing code-server test dependencies...'
echo "Installing code-server test dependencies..."

cd test
yarn install
cd ..

cd vendor
echo 'Installing vendor dependencies...'
echo "Installing vendor dependencies..."

# * We install in 'modules' instead of 'node_modules' because VS Code's extensions
# use a webpack config which cannot differentiate between its own node_modules
Expand All @@ -21,7 +21,14 @@ main() {
# devDependencies are not needed, and that even git repo based packages are
# assumed to be compiled. Because the default behavior for VS Code's `postinstall`
# assumes we're also compiled, this needs to be ignored.
yarn install --modules-folder modules --ignore-scripts --frozen-lockfile

local args=(install --modules-folder modules --ignore-scripts)

if [[ ${CI-} ]]; then
args+=("--frozen-lockfile")
fi

yarn "${args[@]}"

# Finally, run the vendor `postinstall`
yarn run postinstall
Expand Down
1 change: 1 addition & 0 deletions docs/MAINTAINING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
Current maintainers:

- @code-asher
- @TeffenEllis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

- @oxy
- @jsjoeio

Expand Down
2 changes: 1 addition & 1 deletion vendor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"postinstall": "./postinstall.sh"
},
"devDependencies": {
"code-oss-dev": "cdr/vscode#96a09a7846538c3bbedb6a2aeca729537bb8202b"
"code-oss-dev": "cdr/vscode#9cb5fb3759f46b10bc66e676fa7f44c51e84824b"
}
}
Loading