-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Make native-keymap and keytar optional dependencies #4192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4192 +/- ##
=======================================
Coverage 64.22% 64.22%
=======================================
Files 36 36
Lines 1873 1873
Branches 379 379
=======================================
Hits 1203 1203
Misses 569 569
Partials 101 101 Continue to review full report at Codecov.
|
✨ Coder.com for PR #4192 deployed! It will be updated on every commit.
|
- Fix issue where yarn lock cannot be updated in development.
47c9134
to
76a2116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Curious about @edvincent's comment here coder/vscode@07bcbc3#commitcomment-56613657
@@ -20,6 +20,7 @@ | |||
Current maintainers: | |||
|
|||
- @code-asher | |||
- @TeffenEllis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@jsjoeio I'm keeping an eye on the above build, to test with the NPM artifact and report back on that comment - I'm myself curious of exactly what does (or doesn't) happen on installs. |
Dang, you rock! We really appreciate the help! |
Yup it all seems to work as expected when pulling them as optional dependencies! 🎉 The errors are still there, but are now warnings. All the other installs still go through (instead of the install exiting because of the error). code-server seems usable and doesn't seem to be having any issue from what I can see / clicking around so far. |
Hooray! Thanks so much for reporting and helping us test the fix @edvincent! We really appreciate it 🙌 |
This PR addresses a regression introduced in our VS code fork. Previously, we removed two dependencies which required additional native packages, however they were included in the latest release. Rather than remove these and break the desktop build, we now mark them as optional: coder/vscode@07bcbc3
Fixes #4179