Skip to content

fix(readme): tls docs path #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

galesky
Copy link
Contributor

@galesky galesky commented Aug 11, 2021

The link to the --link docs that relate to TLS is broken (404) as it is pointing to a previous release version whose docs are not available.
This PR updates the docs URL.

I've also run a search on the project to make sure no other links using that version where there and I haven't found any.

As an extra, I'd suggest using the latest path rather than a specific version

p.s. I've skipped creating an issue as per docs:
Please create a GitHub Issue that includes context for issues that you see. You can skip this if the proposed fix is minor.

@galesky galesky requested a review from a team as a code owner August 11, 2021 13:00
@galesky galesky mentioned this pull request Aug 11, 2021
2 tasks
Copy link
Contributor

@GirlBossRush GirlBossRush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. And yes, a latest version path would be a great addition in the near future.

@GirlBossRush GirlBossRush enabled auto-merge (rebase) August 11, 2021 15:02
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #3953 (59993cf) into main (316c3aa) will not change coverage.
The diff coverage is n/a.

❗ Current head 59993cf differs from pull request most recent head fb350c1. Consider uploading reports for the commit fb350c1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3953   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316c3aa...fb350c1. Read the comment docs.

@GirlBossRush GirlBossRush merged commit f94e433 into coder:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants