Skip to content

release: 3.11.2 #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

release: 3.11.2 #3940

wants to merge 1 commit into from

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 9, 2021 •
edited
Loading

This PR is to generate a new release of code-server at 3.11.2.

Notes: we're publishing this because we had a hiccup releasing 3.11.1 to npm.

Screenshot

Screen.Recording.2021-08-09.at.4.07.39.PM.mov

TODOs

Follow "Publishing a release" steps in ci/README.md

  • publish release and merge PR
  • update the AUR package

@jsjoeio jsjoeio self-assigned this Aug 9, 2021
@jsjoeio jsjoeio requested a review from a team August 9, 2021 22:22
@jsjoeio jsjoeio linked an issue Aug 9, 2021 that may be closed by this pull request
release: 3.11.2 #3938
Closed
4 tasks
@jsjoeio jsjoeio added this to the 3.11.2 milestone Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #3940 (90f6330) into main (cde28a0) will not change coverage.
The diff coverage is n/a.

❗ Current head 90f6330 differs from pull request most recent head 734a9a1. Consider uploading reports for the commit 734a9a1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3940   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde28a0...734a9a1. Read the comment docs.

jawnsy
jawnsy approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jsjoeio jsjoeio marked this pull request as ready for review August 9, 2021 22:41
jsjoeio referenced this pull request Aug 9, 2021
@jsjoeio
chore(release): bump version to 3.11.1
911af40
@jsjoeio jsjoeio marked this pull request as draft August 9, 2021 23:11
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 9, 2021

Heads-up. I am moving back to draft because I'm seeing the ripgrep error. I think this is a direct result of the symlink removal. I'm not sure why it didn't show up in the PR where we removed it while testing. I think I'll check-in with @code-asher tomorrow

 ERR spawn /Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/node_modules/vscode-ripgrep/bin/rg ENOENT: Error: spawn /Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/node_modules/vscode-ripgrep/bin/rg ENOENT
    at Object.M [as deserializeSearchError] (http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2000:5630)
    at http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2003:5041
    at async http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2003:3078
    at async li.getFileSearchResults (http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2478:11248)
    at async Promise.all (index 0)
    at async li.doFileSearch (http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2478:10892)

galesky
galesky reviewed Aug 11, 2021
View reviewed changes
docs/README.md
@@ -51,7 +51,7 @@ When done, the install script prints out instructions for running and starting
code-server.

We also have an in-depth [setup and
configuration](https://coder.com/docs/code-server/v3.11.1/guide) guide.
configuration](https://coder.com/docs/code-server/v3.11.2/guide) guide.

## TLS and authentication (beta)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL will break as per #3953

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really comment on the correct line - I mean L58

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh! Nice catch! (And thanks for your other PR!)

As an extra, I'd suggest using the latest path rather than a specific version

Yes, this is a great idea and I should probably change that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to do in a follow-up PR since I'm closing this: #3963

@jsjoeio jsjoeio mentioned this pull request Aug 11, 2021
Closed
@jsjoeio jsjoeio closed this Aug 11, 2021
@jsjoeio jsjoeio deleted the v3.11.2 branch August 11, 2021 21:51
@jsjoeio jsjoeio modified the milestones: 3.11.2, 3.12.0 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galesky galesky galesky left review comments

@jawnsy jawnsy jawnsy approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

release: 3.11.2
3 participants
@jsjoeio @jawnsy @galesky