Skip to content

fix: openFolder button on Explorer panel #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix: openFolder button on Explorer panel #3728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/vscode/src/vs/workbench/contrib/files/browser/explorerViewlet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,15 @@ viewsRegistry.registerViewWelcomeContent(EmptyView.ID, {
order: 1
});

// NOTE@coder:
// We use OpenFolderAction.ID instead of commandId
// because for some reason, the command openFileFolder
// does not work as expected and causes the "Open Folder"
// command to not work
// See: https://github.com/cdr/code-server/issues/3457
viewsRegistry.registerViewWelcomeContent(EmptyView.ID, {
content: localize({ key: 'noFolderHelp', comment: ['Please do not translate the word "commmand", it is part of our internal syntax which must not change'] },
"You have not yet opened a folder.\n[Open Folder](command:{0})", commandId),
"You have not yet opened a folder.\n[Open Folder](command:{0})", OpenFolderAction.ID),
when: ContextKeyExpr.or(ContextKeyExpr.and(WorkbenchStateContext.notEqualsTo('workspace'), RemoteNameContext.isEqualTo('')), ContextKeyExpr.and(WorkbenchStateContext.notEqualsTo('workspace'), IsWebContext)),
group: ViewContentGroups.Open,
order: 1
Expand Down