Skip to content

fix: openFolder button on Explorer panel #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 6, 2021

This PR fixes a bug with the "Open Folder" button not working as expected due to a "missing command". The fix is simply using the openFolder command instead of the openFileFolder.

Screenshot

Screen.Recording.2021-07-06.at.2.04.08.PM.mov

Fixes #3457

@jsjoeio jsjoeio self-assigned this Jul 6, 2021
@jsjoeio jsjoeio added the bug Something isn't working label Jul 6, 2021
@jsjoeio jsjoeio changed the title wip fix: openFolder button on Explorer panel Jul 6, 2021
@jsjoeio jsjoeio marked this pull request as ready for review July 6, 2021 21:09
@jsjoeio jsjoeio requested a review from a team as a code owner July 6, 2021 21:09
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #3728 (69277b7) into main (102f811) will not change coverage.
The diff coverage is n/a.

❗ Current head 69277b7 differs from pull request most recent head 990414c. Consider uploading reports for the commit 990414c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3728   +/-   ##
=======================================
  Coverage   61.55%   61.55%           
=======================================
  Files          35       35           
  Lines        1813     1813           
  Branches      365      365           
=======================================
  Hits         1116     1116           
  Misses        588      588           
  Partials      109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102f811...990414c. Read the comment docs.

@jsjoeio jsjoeio merged commit 6f7ae29 into main Jul 6, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-open-folder-explorer-panel branch July 6, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open folder on Explorer panel
2 participants