Override existing asar symlink in postinstall #3369
Conversation
This ensures the link is correct. Should fix coder#3355.
Codecov Report
@@ Coverage Diff @@
## main #3369 +/- ##
=======================================
Coverage 58.95% 58.95%
=======================================
Files 35 35
Lines 1703 1703
Branches 374 374
=======================================
Hits 1004 1004
Misses 561 561
Partials 138 138 Continue to review full report at Codecov.
|
| @@ -56,18 +56,21 @@ main() { | |||
| fi | |||
| } | |||
|
|
|||
| # This is a copy of symlink_asar in ../lib.sh. Look there for details. | |||
There was a problem hiding this comment.
can we import that lib and share code instead of duplicating it? we have a general problem (especially in our other projects) that we have unnecessary copies of things, and that often results in inconsistencies between those files over time
There was a problem hiding this comment.
Yeah that makes a lot of sense, in fact they were already out of sync with this version using -e and the other using -L. I opened #3371
|
So what's up with all of this |
|
Sorry what's up Codcov |
This ensures the link is correct. Should fix #3355.