Share lib script with npm postinstall script #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

code-asher opened this issue May 12, 2021 · 1 comment

Labels

Milestone

Member

code-asher commented May 12, 2021

Change lib.sh to use sh to match the postinstall script.
Will need to change some syntax like remove local. Will need to do something about pushd/popd as well. (Alternatively we could move the arch and asar methods into a separate shared file).
Include lib.sh in the npm package.
Source lib.sh in the postinstall and remove the duplicated methods.
arch method is slightly different so may need to make some changes there.

The text was updated successfully, but these errors were encountered:

code-asher added the enhancement label

code-asher mentioned this issue

Override existing asar symlink in postinstall #3369

Merged

code-asher added this to the On Deck milestone

jsjoeio mentioned this issue

Fix ci/lib.sh to print error to stderr #3380

Closed

stale bot commented Nov 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

stale bot added the stale label

stale bot closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment