Skip to content

Don't send permessage-deflate header if not supported #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Mar 29, 2021

I have no idea if this fixes #2975 since I don't have a way to test.

TODOS

@code-asher code-asher requested a review from a team as a code owner March 29, 2021 17:27
@code-asher
Copy link
Member Author

The sed examples in that issue set permessageDeflate to false and comment out the response header.

However, I'm not sure why permessageDeflate is set to false. Is Safari reporting that it supports permessage-deflate when it doesn't really?

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 29, 2021

Seeing if I can help out by testing locally on my iPad:

  1. gh pr checkout 2993
  2. yarn && yarn watch --link - run with code-server link to be able to access from iPad
  3. open in Safari on iPad

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 29, 2021

Before this change

Reproducing on main i.e. 3.9.2 - blank screen. Won't load.
369A396B-D1A3-430B-8631-A92921D93859

After this change

Pulled down this branch and ran fine without issues

IMG_0201.MP4

@jsjoeio jsjoeio added this to the v3.9.3 milestone Mar 29, 2021
@code-asher code-asher merged commit 18ace7b into coder:main Mar 29, 2021
@code-asher code-asher deleted the ipad-permessage-deflate branch March 29, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New 3.9.2 not work on iPadOS, Safari
2 participants