Skip to content

[dev]: enable end-to-end test suite on Safari and Firefox #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Mar 29, 2021 · 0 comments · Fixed by #3133
Closed

[dev]: enable end-to-end test suite on Safari and Firefox #2998

jsjoeio opened this issue Mar 29, 2021 · 0 comments · Fixed by #3133
Assignees
@jsjoeio
Labels
enhancement Some improvement that isn't a feature testing Anything related to testing
Milestone
v3.10.0

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 29, 2021 •
edited
Loading

Currently, we only run end-to-end tests on Chrome. However, playwright supports all modern browsers:

Single API to automate Chromium, Firefox and WebKit.

After shipping a feature that causes code-server to not work in Safari, we think it's time to enable this.

Related:
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Mar 29, 2021
@jsjoeio jsjoeio added this to the v3.9.3 milestone Mar 29, 2021
@jsjoeio jsjoeio self-assigned this Mar 29, 2021
This was referenced Mar 29, 2021
Merged
Closed
@jsjoeio jsjoeio changed the title Enable end-to-end test suite on Safari [dev]: enable end-to-end test suite on Safari Apr 1, 2021
@jsjoeio jsjoeio mentioned this issue Apr 1, 2021
Merged
6 tasks
@jsjoeio jsjoeio modified the milestones: v3.9.3, On Deck, v3.9.4 Apr 2, 2021
@jsjoeio jsjoeio changed the title [dev]: enable end-to-end test suite on Safari [dev]: enable end-to-end test suite on Safari and Firefox Apr 12, 2021
@jsjoeio jsjoeio mentioned this issue Apr 14, 2021
Merged
3 tasks
@jsjoeio jsjoeio linked a pull request Apr 14, 2021 that will close this issue
refactor(testing): migrate to playwright-test from jest-playwright #3133
Merged
3 tasks
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
enhancement Some improvement that isn't a feature testing Anything related to testing
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging a pull request may close this issue.

refactor(testing): migrate to playwright-test from jest-playwright coder/code-server
1 participant
@jsjoeio