refactor: add check for artifacts url in lib.sh #2968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
requested changes
Mar 25, 2021
jsjoeio
force-pushed
the
jsjoeio/fix-lib-sh
branch
from
b181752 to
7f64c38
Compare
code-asher
approved these changes
Mar 25, 2021
jsjoeio
force-pushed
the
jsjoeio/fix-lib-sh
branch
from
7f64c38 to
67b928c
Compare
jsjoeio
force-pushed
the
jsjoeio/fix-lib-sh
branch
from
67b928c to
27ede67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
lib.shto catch and report an error getting the get_artifacts_url.It was noticed while working on a release in #2953.