Skip to content

Yarn package version not updated #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aptalca opened this issue Mar 25, 2021 · 8 comments
Closed

Yarn package version not updated #2972

aptalca opened this issue Mar 25, 2021 · 8 comments

Comments

@aptalca
Copy link

aptalca commented Mar 25, 2021

Hi,

I noticed the yarn package version is still 3.9.1
Is it forgotten or was there an issue with the update?
In the past the update on there was more or less in sync with the GitHub releases.

Thanks

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 25, 2021

Thanks for being so quick to notice @aptalca! Yes, when we released 3.9.2 something broke in our publish workflow: https://github.com/cdr/code-server/actions/runs/688144994

Once #2968 passes and we merge it, I'm going to trigger a manual publish, which should publish the new version to npm, etc.

@aptalca
Copy link
Author

aptalca commented Mar 26, 2021

I wish I could take credit 😅 Our ci notified me: https://ci.linuxserver.io/blue/organizations/jenkins/Docker-Pipeline-Builders%2Fdocker-code-server/detail/master/218/pipeline

It is triggered by GitHub releases but uses yarn to install. Perhaps we should change it so it's triggered by yarn registry instead.

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 26, 2021

Woah! Super cool that y'all have that set up.

Perhaps we should change it so it's triggered by yarn registry instead

Yeah that could be safer. Though we are working on improving our CI flow! This release today has showed the process is more fragile than it should be 😅

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 26, 2021

Heads-up: we're still running into issues with our publish workflow and scripts. We will continue looking into this first thing tomorrow.

@PatrickDerichs
Copy link

Oh, this is interesting! I noticed that it affects your install script as well, but I am not sure if it is related. We build an image with code-server with a reverse proxy and I noticed it kept building with version 3.9.1. I was able to work around it by passing --version 3.9.2 to forcefully install the new version.

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 26, 2021

Interesting! Thanks for the report @PatrickDerichs - we'll have to confirm once we get this fixed if that's a bug as well.

@aptalca
Copy link
Author

aptalca commented Mar 26, 2021

Heads-up: we're still running into issues with our publish workflow and scripts. We will continue looking into this first thing tomorrow.

Thanks for the heads up. We changed the trigger to check the yarn registry instead so we don't have hourly failing builds anymore. Once you fix your pipeline and push to yarn, our ci should pick it up.

Thanks

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 26, 2021

The issue has been resolved and 3.9.2 is now available on the npm registry.
image

We've also written a regression report which you can read here: #2983

@jsjoeio jsjoeio closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants