-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix(lib/vscode): remove native-keymap and keytar #2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just confused about the native-keymap
declaration file if we're removing the dependency
Update: I spent the day investigating I put that change in this PR too, since it felt like the logical thing to do (they touch nearly the same lines in the Dockerfiles, which means that if I made two PRs, one would have to be rebased and have conflicts resolved). There's some scarier stuff going on with how
For the web, VSCode already includes I've tested this by writing a custom VSCode extension that uses "keytar" injected by vscode to set credentials, and it successfully stores them in LocalStorage. I also tested against GH Codespaces, which shows the same behavior. I've also added notes to the |
6f4981b
to
76eb78f
Compare
@@ -106,7 +104,6 @@ | |||
"@types/graceful-fs": "4.1.2", | |||
"@types/gulp-postcss": "^8.0.0", | |||
"@types/http-proxy-agent": "^2.0.1", | |||
"@types/keytar": "^4.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for review: @types/keytar
is deprecated since keytar
includes types - I removed both and added a typings
file.
native-keymap and keytar are only used in the electron process, so we don't need them. This allows us to drop our dependencies on libx11-dev, libxkbfile-dev, and libsecret-dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
native-keymap is only used in the electron process, so we don't need it.
This allows us to drop our libx11 and libxkbfile build dependencies.