Skip to content

feat: add prettier-plugin-sh #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2021
Merged

feat: add prettier-plugin-sh #2891

merged 3 commits into from
Mar 15, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 15, 2021

This PR adds prettier-plugin-sh and removes shfmt.

Note: it makes some minor modifications to the way our .sh files looked before. I tried setting some of the parser options based on the docs but nothing seemed to work so left it as is. It uses the default options based on mvdan/sh

@jsjoeio jsjoeio requested a review from a team as a code owner March 15, 2021 22:14
@jsjoeio jsjoeio self-assigned this Mar 15, 2021
@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 15, 2021
jawnsy
jawnsy previously approved these changes Mar 15, 2021
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsjoeio jsjoeio merged commit acb4663 into main Mar 15, 2021
@jsjoeio jsjoeio deleted the jsjoeio/replace-shfmt branch March 15, 2021 23:32
@SuperSandro2000
Copy link
Contributor

SuperSandro2000 commented Mar 25, 2021

Whats the motivation behind this? Just curious.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 25, 2021

@SuperSandro2000 guessing you found this answer but if not, this: #2771 (comment)

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants