Skip to content

[dev]: replace shfmt dependency #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Feb 25, 2021 · 1 comment
Closed

[dev]: replace shfmt dependency #2772

jsjoeio opened this issue Feb 25, 2021 · 1 comment
Assignees
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 25, 2021

As discussed in #2771 (comment), it seems silly to require Go and one dependency to contribute to code-server.

Alternative Options

  • make all dev commands run in our dev container so then the only dependency is Docker.
  • use a prettier plugin like prettier-plugin-sh
  • something else

The goal of this issue is to replace the use of shfmt in code-server.

@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Feb 25, 2021
@jsjoeio jsjoeio added this to the v3.9.2 milestone Feb 25, 2021
@jsjoeio jsjoeio changed the title Replace shfmt dependency [dev]: replace shfmt dependency Mar 2, 2021
@jsjoeio jsjoeio self-assigned this Mar 15, 2021
@code-asher
Copy link
Member

Fixed in #2891.

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

2 participants