-
Notifications
You must be signed in to change notification settings - Fork 5.9k
dev(testing): separate unit and e2e tests #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.eslintrc.yaml
Outdated
[ | ||
error, | ||
{ | ||
alphabetize: { order: "asc" }, | ||
groups: [["builtin", "external", "internal"], "parent", "sibling"], | ||
}, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄
e09359a
to
5a5c78a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the off
-> 0
thing, LGTM otherwise!
5a5c78a
to
7e23575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR fixes #2646 by separating unit and e2e testing. Hopefully this speeds things up with CI.