Skip to content

[dev]: separate unit and end-to-end testing #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Jan 28, 2021 · 0 comments · Fixed by #2852
Closed

[dev]: separate unit and end-to-end testing #2646

jsjoeio opened this issue Jan 28, 2021 · 0 comments · Fixed by #2852
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature testing Anything related to testing
Milestone
v3.9.2

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 28, 2021 •
edited
Loading

In the future, we should consider separating the tests. We could have test:unit and test:e2e and then have separate jobs for each in ci.

When #2643 gets merged, running yarn test will only work if you have code-server running. Not ideal.

Instead, we should separate them and make it so both unit tests and e2e tests can be run locally and separately in ci.
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Jan 28, 2021
@jsjoeio jsjoeio mentioned this issue Jan 28, 2021
Merged
2 tasks
@jsjoeio jsjoeio mentioned this issue Feb 10, 2021
Closed
@jsjoeio jsjoeio added this to the v3.9.2 milestone Feb 24, 2021
@jsjoeio jsjoeio changed the title Separate unit and end-to-end testing [dev]: separate unit and end-to-end testing Mar 2, 2021
This was referenced Mar 4, 2021
Closed
Merged
@jsjoeio jsjoeio added testing Anything related to testing chore Related to maintenance or clean up labels May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature testing Anything related to testing
Projects
None yet
Milestone
v3.9.2
Development

Successfully merging a pull request may close this issue.

dev(testing): separate unit and e2e tests coder/code-server
1 participant
@jsjoeio