Skip to content

Remove default home #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

Remove default home #2800

merged 2 commits into from
Mar 2, 2021

Conversation

code-asher
Copy link
Member

No description provided.

@code-asher
Remove default home value
f526ab8 
Closes #2742.
@code-asher
Remove .ignore
9da9ff2 
This is preventing my ripgrep from searching vscode.
@code-asher code-asher changed the title Removeo default home Remove default home Mar 1, 2021
@code-asher code-asher requested a review from a team March 1, 2021 19:21
@code-asher code-asher changed the base branch from v3.9.0 to master March 1, 2021 19:22
@jsjoeio jsjoeio added this to the v3.9.1 milestone Mar 1, 2021
jsjoeio
jsjoeio approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my favorite kind of PRs: short and sweet

  • tested by setting home in config. still works!
  • tested if home icon is removed when home isn't set

image

@greyscaled greyscaled linked an issue Mar 2, 2021 that may be closed by this pull request
Remove default home value #2742
Closed
@code-asher code-asher merged commit 29f3021 into master Mar 2, 2021
@code-asher code-asher deleted the no-default-home branch March 2, 2021 16:13
@reggiezhang
Copy link

"--home" no longer works on v3.9.2

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 29, 2021 •
edited
Loading

@reggiezhang apologies! That should have been mentioned in the release notes (updating now) Added to release notes for 3.9.2.

VS Code removed that option so we had to remove it from code-server here: #2862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

Remove default home value
3 participants
@code-asher @reggiezhang @jsjoeio